[FM-6584] Task test cleanup #1040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmeek
force-pushed
the
task_test_cleanup
branch
7 times, most recently
from
e55a4b0 to
dfa4d8b
Compare
willmeek
force-pushed
the
task_test_cleanup
branch
from
dfa4d8b to
7eda619
Compare
eputnam
reviewed
Dec 19, 2017
| @@ -48,7 +48,7 @@ class { 'mysql::server::backup': | |||
| end | |||
|
|
|||
| it 'dumps all databases to single file #stdout' do | |||
| if version_is_greater_than('5.7.0') | |||
| unless version_is_greater_than('5.7.0') | |||
There was a problem hiding this comment.
was this intentional? it's broken jenkins.
There was a problem hiding this comment.
Yes, this is to fix Jenkins - it was introduced in a recent rubocopificiation work, I added the fix to this PR.
You can view an adhoc run of this branch on Jenkins - https://jenkins-master-prod-1.delivery.puppetlabs.net/view/modules/view/linux/view/mysql/view/adhoc/ - all green :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.